[ refactor ] Exchange components of Relation.Binary.Definitions._Respects₂_#2515
Open
jamesmckinna wants to merge 10 commits intoagda:masterfrom
Open
[ refactor ] Exchange components of Relation.Binary.Definitions._Respects₂_#2515jamesmckinna wants to merge 10 commits intoagda:masterfrom
Relation.Binary.Definitions._Respects₂_#2515jamesmckinna wants to merge 10 commits intoagda:masterfrom
Conversation
Taneb
approved these changes
Dec 9, 2024
Collaborator
|
This is definitely v3.0 I'm afraid. Large breaking change... |
JacquesCarette
approved these changes
Dec 10, 2024
Collaborator
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
v3.0 it might be, but here's my approval anyways.
Collaborator
Author
|
Will resolve the merge conflict only once |
MatthewDaggitt
requested changes
Feb 11, 2025
Collaborator
Author
|
I'll only return to the merge conflicts after v2.3 gets released (or else we fast-forward directly to v3.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2471
Lots of (trivial) knock-on viscosity: PR takes the opportunity to rename/refactor proofs in (hopefully!) helpful ways.
Is this v2.x or v3.0, because
breaking?